github / github/secure_headers

Validation on plugin-types does not allow for the empty directive

Aperta
#448 1 commento 1 reazione 2 assegnatari Rivendicata da @fletchto99 Vedi su GitHub
Lingua principale
Ruby
Stelle
3.2k
Fork
253
Merge medio
19h 11m
PR unite (30g)
1

Descrizione

# Bugs

> Note: The plugin-types grammar allows for an empty directive value in which case all instantions of embed and object will fail.

https://w3c.github.io/webappsec-csp/#directive-plugin-types

We validate it must match something like `application/pdf` which is not correct.

### Expected outcome

Describe what you expected to happen

`plugin_types` should allow for an empty directive. Sending an empty array omits the directive. Sending `none` is not allowed by validation. An array of empty strings doesn't work either (validation)

### Actual outcome

Configuration errors when trying to do the right thing

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.