github / github/scientist

Allow setting raise_on_mismatches to base class level for tests

Ouverte
#174 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Ruby
Étoiles
7.8k
Forks
505
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

We are using a base experiment class to manage our publish logic. All the actual experiments are extending from this base class. However, if we set raise_on_mismatches to this base class the result doesn't take effect as the method is using class instance variables(instead of class variables). In the end, people occasionally forget to use this test helper for their newly created experiments.

It would be great if we can manage this test helper via a base class. To elaborate more on this, this is somewhat our structure;

```ruby
class BaseExperiment
include Scientist::Experiment

def initialize
# setting up some instance variables mainly needed for publish logic
end

def publish(result)
# some custom logic
end
end

class WidgetExperiment < BaseExperiment
def initialize
# setting up custom variables
super
end

def enabled?
# custom enabled logic
end
end

class AnotherExperiment < BaseExperiment
# similar context with widget experiment
end
```

What we want is to use `BaseExperiment.raise_on_mismatches = true` to ensure all child experiments are tested on tests without needed a separate test setup. Would such a need make sense to you?

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.