github / github/rubocop-github

Unify controller render cops?

Open
#34 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Ruby
Stars
667
Forks
164
PR merge metrics
No merged PRs in 30d

Description

It looks like there are several cops which implement various approaches to recommending:

```ruby
render "path/to/template", { ... options ... }
```

Why are these cops separate? Could they be unified?

For example, one cop replaces `render action: :edit` => `render action: "edit"`, but another replaces `render action: "edit"` => `render "edit"`. So, could we jump right from `render action: :edit"` => `render "edit"`?

Contributor guide

Open the contributing guide

Research direction

The issue does not name files or tests. Start by locating the controller render cops that handle symbol and string actions, then compare their recommendations and correction behavior. Done means determining whether the cops can be unified and defining a consistent direct correction from `render action: :edit` to `render "edit"`.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.