github / github/relative-time-element

Inconsistent use of "yesterday"

Abierto
#313 1 comentario 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
JavaScript
Estrellas
4k
Forks
192
Merge medio
1 d 10 h
PR fusionados (30 d)
5

Descripción

Using relative-time-element v4.4.5.

I am in a UTC-5 time zone. The current time for me is April 30 1:53PM (2025-04-30 18:53 UTC).

I've set up a test page at https://greasyfork.org/en/relative_date_test to show the last 48 hours of ``. Here is what I see:

![Image](https://github.com/user-attachments/assets/63a20139-aaff-45a6-84f6-34e088372a67)

- 0 hours ago shows "now", no issue.
- 1 - 13 hours ago (Apr 30 for me) - shows as "x hours ago", no issue.
- 14 - 20 hours ago (Apr 29 for me) - shows as "x hours ago", could also show as "yesterday", but that's fine.
- 21 - 35 hours ago (Apr 29 for me) - shows as "yesterday", no issue.
- **36 - 37 hours ago (Apr 29 for me) - shows as "2 days ago".**
- 38 - 48 hours ago (Apr 28 for me) - shows as "2 days ago", no issue.

36 and 37 hours ago for me is Apr 29 12:53AM and 1:53AM, which is still "yesterday", not "2 days ago". Especially weird that then Apr 29 2:53AM _is_ "yesterday".

I imagine that maybe "1.5 days ago" is getting rounded up to "2 days ago", but "yesterday" is a concept of calendar dates and not a number of hours, so there's no reason to stop using that term until it's no longer 1 calendar day ago.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Start with the linked relative_date_test page and reproduce the reported behavior using relative-time-element v4.4.5 in the UTC-5 example. Trace the relative-time rendering entry point and verify that timestamps 36–37 hours old still display “yesterday” when they fall on the previous local calendar date, while timestamps from two calendar dates ago display “2 days ago”.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
javascript
Área
frontend
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
45/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.