github / github/relative-time-element

Title format is not configurable

Aperta
#272 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
4k
Fork
192
Merge medio
1g 10h
PR unite (30g)
5

Descrizione

Hello, and thanks for this custom element!

I am starting to use `` in an app that supports multiple languages and users are in different countries. I started with the basics and just set the `datetime` attribute and inner text.

I noticed the automatic `title` always had short months. I tried to change it by setting `formatStyle="long"` and `month="long"` to no avail. Inspecting the source I found that titles use a fixed format:

https://github.com/github/relative-time-element/blob/7e40806f21684e46573e202527b9505e723d13e8/src/relative-time-element.ts#L116-L130

Thanks to the comment in the code above, I was able to temporarily solve for my use case by rendering the title from the server side, but that meant giving up showing the time in the timezone of the browser.

Would you consider re-using the style settings when formatting the title or provide a specific formatting rule for the title, independent from the inner text?

PS: Related, but less important, it would also be useful to add some text around the date, like `title="Updated at {formatted-date-here}"` (where the string "Updated at" is rendered in the correct locale on the server).

Thanks again!

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start with src/relative-time-element.ts at the title-formatting code linked in the issue, then inspect the existing formatting options and related tests. Define and implement how title formatting reuses the style settings or accepts an independent rule, while preserving browser-local timezone formatting; done means the title supports the requested localized format.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
javascript
Ambito
frontend, localization
Tipo di issue
Funzionalità
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
42/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.