github / github/platform-samples
Problem with pre-receive hook if there is whitespace character in file/folder name
- Vorherrschende Sprache
- Shell
- Sterne
- 2.2k
- Forks
- 1.9k
- Ø Merge
- 7 T. 19 Std.
- Gemergte PRs (30 T.)
- 1
Beschreibung
Hello,
This is a suggestion for a change in: "pre-receive-hooks/block_file_extensions.sh". When you try to push an blob object, which has whitespace in its name, the current loop will break. My suggestion is to transform:
```
for FILE in `git log -1 --name-only --pretty=format:'' $COMMIT`;
do
case $FILE in
*.zip|*.gz|*.tgz )
echo "Hello there! We have restricted committing that filetype. Please see Dave in IT to discuss alternatives."
exit 1
;;
esac
done
```
into:
```
while IFS= read -r FILE; do
case "$FILE" in
*.zip|*.gz|*.tgz )
echo "Hello there! We have restricted committing that filetype. Please see Dave in IT to discuss alternatives."
exit 1
esac
done <<< "$(git log -1 --name-only --pretty=format:'' $COMMIT)"
```
Beitragsleitfaden
Rechercherichtung
Start with pre-receive-hooks/block_file_extensions.sh and inspect how the current git log output is iterated. Reproduce the hook with a file or folder name containing whitespace, then verify that the restricted extensions are still rejected and whitespace-containing names are processed correctly.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- git, shell
- Bereich
- devops
- Issue-Typ
- Bug
- Schwierigkeit
- 2/5
- Geschätzter Aufwand
- 1-3 Stunden
- Aktivitätsstatus
- Veraltet
- Klarheit
- Klar beschrieben
- Anfängerfreundlichkeit
- 50/100