baseurl of '/' now breaks on GitHub pages
- Lingua principale
- Ruby
- Stelle
- 1.9k
- Fork
- 360
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
### Before submitting an issue, please be sure to
- [x] Read [the contributing instructions](https://github.com/github/pages-gem/blob/master/CONTRIBUTING.md#contributing-to-the-github-pages-gem)
- [x] Update to the latest Gem version (run `bundle update github-pages`)
### This issue affects
- [x] The site generated by GitHub Pages
- [ ] Building sites locally
### What did you do (e.g., steps to reproduce)
I pushed my site with a small change from the last push couple of weeks ago.
### What did you expect to happen?
The site to appear as it has done for years :)
### What happened instead?
All the styling is lost, because the upgrade to jekyll-github-metadata v2.5.0 means that a config with baseurl set to `/` is now overridden to baseurl `""` and the templates were relying on baseurl being set to `/`. I understand that `baseurl: "/"` is incorrect and shouldn't be used (though I can't find any official documentation saying why this shouldn't work okay, only links to Parker's [2014 blog post](https://byparker.com/blog/2014/clearing-up-confusion-around-baseurl/)), but anyway, I didn't expect the whole site to break by adding a new blog post :)
### Additional information
* Link to the live site (if applicable): http://fixmystreet.org/overview/ (now fixed by https://github.com/mysociety/fixmystreet/commit/f3bb932c1b7f09fd4bffef2ef403c11008f9fcb0)
* Link to the source repo (if applicable): https://github.com/mysociety/fixmystreet/tree/a1dfd4acb844162227c27d4e19c6e863cc96a692
Guida per i contributori
Apri la guida per i contributori
Direzione di ricerca
Inizia riproducendo la build di GitHub Pages con baseurl impostato su "/" e jekyll-github-metadata v2.5.0, usando come riferimenti il repository sorgente collegato e il sito live. Traccia il percorso del valore di configurazione fino ai template e identifica gli URL degli asset generati rilevanti; il lavoro è completato quando il sito mantiene il proprio stile senza compromettere il comportamento documentato di baseurl.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- ruby
- Ambito
- build-system
- Tipo di issue
- Bug
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Stato di attività
- Ferma
- Chiarezza
- Da chiarire
- Idoneità per principianti
- 28/100