github / github/mini-throttle

The throttle is not performing as expected.

Ouverte
#23 0 commentaires 4 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
TypeScript
Étoiles
229
Forks
18
Merge moyen
1 j 10 h
PR mergées (30 j)
2

Description

The throttle of this library does not perform throttling (it behaves differently from what is described in the tests and documentation).

You will understand if you try the following reproduction code in [RunKit](https://npm.runkit.com/%40github%2Fmini-throttle). Instead of behaving like [the marble in the test cases](https://github.com/github/mini-throttle/blob/7fb6f52c98c735fe44f6096c8bddd051976d3ae0/test/index.ts#L167), it appears to perform a complete debounce operation, firing only once at the start and once at the end.

> | throttle(fn, 100) | 1 2 4 6 8 10 |

![image](https://github.com/github/mini-throttle/assets/7282145/454d4d46-014a-45ca-88ec-0ddcb03a7342)

```javascript
var {throttle} = require("@github/mini-throttle")

const delay = (m) => new Promise(r => setTimeout(r, m))

const fn = throttle((...x)=>{console.log(x)},1000)

for (let i = 1; i <= 10; ++i) {
fn(i)
await delay(100)
}
await delay(1000)
```

---

You can also repro this in the following CodeSandbox. Please rapidly click the button. While the expected throttle behavior is that of lodash.throttle, but mini-throttle does not perform as its name "throttle".

https://codesandbox.io/p/sandbox/damp-browser-fyd2g4?file=/src/index.js:24,11

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.