github / github/markup

Asciidoctor: support include directives for other asciidoc files

Open
#1,095 160 comments 313 reactions 0 assignees View on GitHub
Dominant language
Ruby
Stars
6k
Forks
3.4k
PR merge metrics
No merged PRs in 30d

Description

A lot of time has passed since latest comments from devs in #172 and #335.
I think after years things have changed in your infrastructure, why not to bring up this issue again with some more input and news?

For example, AFAIK GitHub started to use [containers](https://githubengineering.com/kubernetes-at-github/) which could help to isolate things from unintentional access and improve security.

Also take a look at asciidoctor/asciidoctor#1088. The author of Asciidoctor is [ready for a conversation](https://github.com/asciidoctor/asciidoctor/issues/1088#issuecomment-323672651) about this, there is even proposed a way to implement this with [custom include preprocessor](https://github.com/asciidoctor/asciidoctor/issues/1088#issuecomment-87685739). If there are still some concerns about resolving the issue, please provide a constructive feedback so both sides can collaborate.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.