github / github/markdown-toolbar-element
Hotkeys don't work on Windows with non en-us keyboard layout
- Vorherrschende Sprache
- JavaScript
- Sterne
- 411
- Forks
- 60
- Ø Merge
- 2 T. 22 Std.
- Gemergte PRs (30 T.)
- 6
Beschreibung
Current way of matching hotkey with `event.key` property leads to broken hotkeys on Windows (Chrome, Vivaldi at least) as, for example with ru-RU locale on keybord hitting cmd+b will send event with `key` property set to cyrillic "и" and not "b".
First it was found in https://github.com/umputun/remark/issues/404
Images provided by @Andrew-Shtein prove difference in `key` prop
Issue located here:
https://github.com/github/markdown-toolbar-element/blob/dd0ffba8d9ad9d64471d3be41b3b7e1b77aa3545/index.js#L228-L236
Beitragsleitfaden
Bewertung
Dieses Issue wurde noch nicht bewertet.