github / github/markdown-toolbar-element
Hotkeys don't work on Windows with non en-us keyboard layout
- Dominant language
- JavaScript
- Stars
- 411
- Forks
- 60
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 6
Description
Current way of matching hotkey with `event.key` property leads to broken hotkeys on Windows (Chrome, Vivaldi at least) as, for example with ru-RU locale on keybord hitting cmd+b will send event with `key` property set to cyrillic "и" and not "b".
First it was found in https://github.com/umputun/remark/issues/404
Images provided by @Andrew-Shtein prove difference in `key` prop
Issue located here:
https://github.com/github/markdown-toolbar-element/blob/dd0ffba8d9ad9d64471d3be41b3b7e1b77aa3545/index.js#L228-L236
Contributor guide
Assessment
This issue has not been assessed yet.