github / github/include-fragment-element
<include-fragment> and Screen Reader Accessibility
- Lenguaje dominante
- JavaScript
- Estrellas
- 568
- Forks
- 43
- Merge medio
- 1 d 6 h
- PR fusionados (30 d)
- 5
Descripción
I have the following issue.
I'm a totally blind software engineer and use a screen reader. Obviously, in our company we use Github for managing code. I'm used to review pull requests without any hassles, but recently _that_ has started.
In our company larger pull requests are common (that's debatable whether it's good or bad, but it is as it is). I had to review a pull request containing 54 changed files. With my screen reader I could see only 18 first diffs rendered, then there was nothing at all, nada. The remaining diffs were however visible on screen for sighted people.
When inspecting the source code of the page in my browser, I saw that the first 18 diff tables are indeed rendered correctly, then there is an `` element with a link to all of the remaining diffs. I tried to open that link as a separate web page, but of course I had no luck in seeing comments properly and so on.
My question is: Is it incorrect usage pattern of this library on github or is this library inaccessible in its nature?
this is a huge show stopper for my work. Github has always been an extremely accessible and friendly network to work with, but now it's really disappointing.
Guía de contribución
Línea de trabajo
Comience reproduciendo el comportamiento reportado con un pull request grande e inspeccione cómo el elemento carga los diffs diferidos. Determine si el contenido cargado, incluidos los comentarios, está expuesto correctamente a los lectores de pantalla; el trabajo requiere una corrección de accesibilidad documentada o una explicación clara de la limitación de la biblioteca para considerarse terminado.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- javascript
- Área
- accessibility, frontend
- Tipo de issue
- Error
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Estado de actividad
- Estancado
- Claridad
- Necesita aclaración
- Aptitud para principiantes
- 25/100