github / github/github-mcp-server

Feature: per-toolset (or per-tool) read-only mode instead of global GITHUB_READ_ONLY

Aperta
#3,229 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
enhancement policies & governance
Lingua principale
Go
Stelle
33k
Fork
5k
Merge medio
2g 1h
PR unite (30g)
52

Descrizione

### Feature request

`GITHUB_READ_ONLY` is currently all-or-nothing: when set, the whole server rejects every write operation. There is no way to keep some domains writable while others stay read-only.

### Use case

Running the server as a local coding-agent tool with a single GitHub token, I want a common "safe by default" posture:

- Reads everywhere (repos, issues, pull requests) allowed without human confirmation
- Writes (merge PR, close/label issues, push comments) gated behind explicit user approval

Today the only way to approximate this is to launch **two full server instances** — one with `GITHUB_READ_ONLY=1` and one without — and rely on agent-side conventions to route writes to the second instance. That is fragile because nothing on the server side prevents an agent from calling write tools on the writable instance, and it doubles the tool surface / process count.

### Proposed solution

Any of the following would fix it:

1. Per-toolset read-only, e.g. `GITHUB_READ_ONLY_TOOLSETS=issues,pull_requests` (writes rejected only for the listed toolsets), or
2. Per-tool read-only overrides, e.g. a `GITHUB_READ_ONLY_TOOLS=merge_pull_request,create_issue` deny list, or
3. A "write-confirm" layer that rejects write tools unless an opt-in env var for that specific call is present.

Option 1 seems the most consistent with the existing `GITHUB_TOOLSETS` design.

### Alternatives considered

- Token scoping (fine-grained PAT without write scopes): does not help, because the same token is also expected to perform approved writes.
- Dual-instance setup: works only as a convention, not enforcement (described above).

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start by tracing how the server handles GITHUB_READ_ONLY and the existing GITHUB_TOOLSETS configuration, then identify where write tools are dispatched. Compare the proposed per-toolset and per-tool scopes with current configuration behavior. Done means selected write operations are rejected while reads and explicitly permitted writes continue to work, with coverage for the chosen configuration.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
github, go
Ambito
backend-api-design, security
Tipo di issue
Funzionalità
Difficoltà
5/5
Tempo stimato
Più di una settimana
Stato di attività
Attiva
Chiarezza
Abbastanza chiara
Idoneità per principianti
42/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.