github / github/github-mcp-server

http: classify missing token, invalid token, and insufficient scope distinctly

未关闭
#2,213 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Go
星标
33k
派生
5k
平均合并
2 天 1 小时
30 天内合并 PR
52

描述

## Problem
Authentication and authorization failures currently collapse into generic HTTP errors even though missing credentials, invalid/expired credentials, and insufficient scopes require different remediation. That weakens machine-readable diagnostics for hosts and operators.

## Why now
This server sits directly on GitHub token-policy boundaries. Clients and wrappers need explicit failure classification to decide whether to prompt for auth, refresh a token, or request additional scopes.

## Expected behavior
Missing token, invalid/expired token, and insufficient scope paths should each expose a distinct machine-readable error code while preserving the existing auth challenge semantics.

## Claim-to-codepath map
- `pkg/http/middleware/token.go`
- `pkg/http/middleware/pat_scope.go`
- `pkg/http/middleware/scope_challenge.go`
- `pkg/errors/error.go`
- `docs/error-handling.md`

## Evidence packet
- Commit under test: `fa87e4fc9e4cd1f514cf4c236b9135987a328512`
- Runtime: Go HTTP middleware tests on macOS
- Repro concept: exercise requests with no token, malformed/invalid token, and OAuth requests lacking required scopes.

## Validation requirements
- Add targeted middleware/error tests for each classification.
- Preserve `WWW-Authenticate` challenge behavior where applicable.
- Document the new machine-readable codes.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。