github / github/gh-stack

submit marks existing draft PRs ready for review without --open, firing review requests

Aperta
#481 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Go
Stelle
1.5k
Fork
70
Merge medio
1g 8h
PR unite (30g)
7

Descrizione

## Environment

- gh 2.96.0 (2026-07-02), gh-stack **v0.0.4**, git 2.46.1, macOS 26.6

## Summary

`gh stack submit --auto` marked two already-open draft PRs as ready for review, which fired review requests to five CODEOWNERS. I did not pass `--open`.

The help text is explicit that this should not happen:

> New PRs are created as drafts by default. Use `--open` to mark them as ready for review.

## Repro

```
gh stack submit --auto # creates PR A and PR B as drafts
gh pr view A --json isDraft # => true, as documented
# ... make no change to the branches ...
gh stack submit --auto # second run, still no --open
gh pr view A --json isDraft # => false
```

Second run's output, which gives no indication it changed draft state:

```
Checking stack state...
Pushing to origin...
PR #A for branch-a is up to date
PR #B for branch-b is up to date
✓ Stack updated on GitHub with 2 PRs
✓ Pushed and synced 2 branches
```

The PR timeline confirms it:

```
ready_for_review by=
review_requested by= x5
```

Those timestamps match the second `submit` to the second. I made no other change in between, and did not touch the web UI.

## Why it matters

Marking a PR ready is not a local operation. It notifies every CODEOWNER, and on a repo with required reviewers it moves the PR into other people's queues. Doing it on an update pass, from a flag whose documented meaning is "use auto-generated titles without prompting", is surprising in a way that cannot be undone: `gh pr ready --undo` restores draft state but the notifications have already gone out.

It also makes `submit` unusable as an idempotent "sync my stack" command, which is what its output implies it is when everything is already up to date.

## Expected

`submit` should only change draft state when `--open` is passed. If the current behaviour is deliberate for update passes, the help text should say so, and the output should name the change instead of printing `is up to date`.

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Inizia eseguendo la riproduzione segnalata in due passaggi con `gh stack submit --auto` e ispeziona il percorso di aggiornamento del comando `submit`, soprattutto il punto in cui vengono gestite le pull request esistenti. Confronta quel percorso con il comportamento di `--open` e verificalo con `gh pr view A --json isDraft`; il lavoro è completato quando gli invii ripetuti lasciano invariati i draft esistenti, a meno che non venga passato `--open`, e i test coprono la regressione.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
github, go
Ambito
api, cli
Tipo di issue
Bug
Difficoltà
3/5
Tempo stimato
1-2 giorni
Stato di attività
Attiva
Chiarezza
Abbastanza chiara
Idoneità per principianti
58/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.