sync reports success (exit 0) when its internal push fails
- Langage dominant
- Go
- Étoiles
- 1.5k
- Forks
- 70
- Merge moyen
- 1 j 8 h
- PR mergées (30 j)
- 7
Description
(This issue was AI generated but I have read it, understood it, and I'm accountable for its content.)
**Version**: gh-stack v0.1.0.
**Repro**: a stack whose branches are already pushed; rebase the stack locally (tips now require a force-push); run `gh stack sync`.
**Actual output**:
```
Pushing 3 branches to origin...
⚠ Push failed — branches may need force push after rebase
Run `gh stack push` to push with --force-with-lease.
...
✓ Stack synced
```
with **exit code 0**, while the branches were not pushed.
**Expected**: either sync pushes with `--force-with-lease --atomic` as its own documentation describes (step 5 of the sync help text), or the run exits non-zero when the push step fails. A warning followed by a success line and a zero exit makes sync unusable in scripts and easy to misread interactively.
Guide de contribution
Ouvrir le guide de contribution
Piste de recherche
Start at the `gh stack sync` command and trace how the internal push result is handled after a rebased stack requires a force push. Reproduce the reported scenario, then verify that a failed push cannot produce a successful sync result or exit code; add or update a regression test if the surrounding command tests provide one.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- git, go
- Domaine
- cli
- Type d'issue
- Bug
- Difficulté
- 3/5
- Temps estimé
- 1-2 jours
- Activité
- Active
- Clarté
- Plutôt claire
- Accessibilité débutants
- 68/100