Reordering a stack can cause PRs to be incorrectly marked as merged
- Lenguaje dominante
- Go
- Estrellas
- 1.5k
- Forks
- 70
- Merge medio
- 1 d 8 h
- PR fusionados (30 d)
- 7
Descripción
## Problem
After reordering a published stack, I ran:
```bash
gh stack modify
gh stack push
gh stack submit
```
`gh stack push` updated the branch ancestry without updating the existing PR bases. Some PRs then targeted descendant branches that already contained their commits.
GitHub saw empty diffs and automatically marked those PRs as merged, although their commits were never merged into `main`. The PRs could not be reopened and had to be recreated with new branch names.
## Version
`gh stack version 0.0.8`
## Expected behavior
I expected `gh stack push` either
- to update the remote stack to match the reordered local stack,
- or to fail and tell me to use `gh stack submit` for this operation.
Guía de contribución
Línea de trabajo
Start with the implementation behind `gh stack push`, then trace how reordered stack ancestry and existing PR bases are handled. Reproduce the `gh stack modify`, `gh stack push`, and `gh stack submit` sequence from the report; done means push safely synchronizes the remote stack or clearly directs users to submit, without PRs being incorrectly marked as merged.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- github, go
- Área
- cli
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Activo
- Claridad
- Bastante claro
- Aptitud para principiantes
- 48/100