github / github/gh-stack

Stack merge hangs after partial merge invalidates latest-push approval

Ouverte
#174 9 commentaires 22 réactions 0 personnes assignées Voir sur GitHub
bug topic: merge
Langage dominant
Go
Étoiles
1.5k
Forks
70
Merge moyen
1 j 8 h
PR mergées (30 j)
7

Description

## Reproduction

1. Create `main <- PR A <- PR B`.
2. Enable merge queue and "Require approval of the most recent reviewable push."
3. Approve both PRs after their latest pushes.
4. Merge the stack from PR B.

## Expected

Both PRs merge, or the operation stops before either merges.

## Actual

PR A merges. GitHub rebases PR B, invalidating its approval. PR B is not queued, and the merge dialog spins indefinitely.

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Start by reproducing the stacked merge through PR B with merge queue and most-recent-push approval enabled, then trace the merge-queue and merge-dialog flow after PR B's approval is invalidated. Done means the operation either merges both PRs or stops cleanly before either merge, without leaving the dialog spinning.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
github, go
Domaine
cli, devtools
Type d'issue
Bug
Difficulté
3/5
Temps estimé
1-2 jours
Activité
Active
Clarté
Plutôt claire
Accessibilité débutants
55/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.