github / github/gh-stack

Stack merge hangs after partial merge invalidates latest-push approval

Open
#174 9 comments 22 reactions 0 assignees View on GitHub
bug topic: merge
Dominant language
Go
Stars
1.5k
Forks
70
Avg merge
1d 8h
Merged PRs (30d)
7

Description

## Reproduction

1. Create `main <- PR A <- PR B`.
2. Enable merge queue and "Require approval of the most recent reviewable push."
3. Approve both PRs after their latest pushes.
4. Merge the stack from PR B.

## Expected

Both PRs merge, or the operation stops before either merges.

## Actual

PR A merges. GitHub rebases PR B, invalidating its approval. PR B is not queued, and the merge dialog spins indefinitely.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the stacked merge through PR B with merge queue and most-recent-push approval enabled, then trace the merge-queue and merge-dialog flow after PR B's approval is invalidated. Done means the operation either merges both PRs or stops cleanly before either merge, without leaving the dialog spinning.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, go
Domain
cli, devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.