github / github/gh-stack

gh stack modify: modify fails when merged branches have been pruned

未關閉
#146 7 則留言 23 個 reaction 已指派 0 人 在 GitHub 檢視
bug topic: cli - modify
主要語言
Go
星號
1.5k
分支
70
平均合併
1 天 8 小時
30 天內合併 PR
7

描述

Looks like modify can't deal with pruned branches once they have been merged.

See below output:

```
➜ token-scanning-service git:(aerendel/fix-generic-secrets-metadata) gh stack modify
✗ failed to apply modifications: building snapshot: resolving branch SHAs: failed to run git: fatal: ambiguous argument 'aerendel/mixed-content-types1': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git [...] -- [...]'
```

### Observed behavior:
The bottom of my stack has been merged and the branch pruned so it doesn't exist locally or remotely anymore (not unusual once a branch is merged), and all `gh stack modify` operations fail to save. Any operation will fail, wether it's renaming a branch, reorganizing, dropping a branch, etc.

### Repro:
1. Make a stack with 2 or 3 layers
2. Merge the first layer
3. Delete the first layer's branch locally (or just answer Yes to gh stack's prune prompt)
4. Run `gh stack modify` and try to save any modify operation

貢獻指南

開啟貢獻指南

研究方向

Start at the gh stack modify flow and the snapshot step that resolves branch SHAs, then reproduce the issue by pruning the bottom branch of a two- or three-layer stack. Done means renaming, reorganizing, dropping, and other modify operations can save successfully after the merged branch is deleted locally and remotely.

由索引模型根據 Issue 內容生成。

評估

技術堆疊
git, go
領域
cli
Issue 類型
缺陷
難度
3/5
預估耗時
1-2 天
活躍度
活躍
描述清晰度
基本清楚
新手友好度
68/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。