github / github/gh-ost

fail in case of adding unique index by default

Offen
#477 1 Kommentar 0 Reaktionen 1 zugewiesene Person Beansprucht von @shlomi-noach Auf GitHub ansehen
Vorherrschende Sprache
Go
Sterne
13.6k
Forks
1.4k
Ø Merge
2 Std. 31 Min.
Gemergte PRs (30 T.)
4

Beschreibung

Hi,
I'm about https://github.com/github/gh-ost/issues/167.
We're faced with the same behavior and it was unexpected for us.
Previously we used `pt-online-schema-change` and it failed and showed a query to check if there were duplicated entries when it detected adding unique index.
Didn't you think about adding flag like `-allow-unique-key` and fail in case of adding an unique key by default?
Or adding something like `-fail-on-adding-unique-key` which will enable checking for adding an unique key.
`pt-online-schema-change`'s `check-unique-key-change` flag documented here: https://www.percona.com/doc/percona-toolkit/LATEST/pt-online-schema-change.html#id7
It would be great to have the same behavior in `gh-ost`.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.