github / github/email_reply_parser

Signature regular expression

Offen
#53 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Ruby
Sterne
708
Forks
156
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

I ran into some random situations where emails were not parsed correctly. Part of the email was chopped out, for example:
`Hi Test,\n\n-This is a test`
Will result in `-This is a test` fragment being hidden and considered as part of signature which it should not be. After digging more into the problem, we figured out that:
`(?m)(--\s*$|__\s*$|\w-$)|(^(\w+\s*){1,3} ym morf tneS$)`
The first matching group is testing against `\w-`, which is causing the problem. I can't think out of a better way to solve the problem other than take `\w-$` part out so it opens to any suggestion.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.