github / github/elastomer-client

Allow apps to configure faraday logger

Open
#80 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Ruby
Stars
197
Forks
28
PR merge metrics
No merged PRs in 30d

Description

This code in haystack reaches into elastomer-client's Faraday object to set the logger:

```
if Rails.env.development?
Haystack.elastomer_client.connection.response :logger, Rails.logger
end
```

https://github.com/github/haystack/blob/master/config/initializers/elasticsearch.rb#L18-L20

This shouldn't be necessary. Elastomer::Client should provide a method to set a logger object.

Contributor guide

Open the contributing guide

Research direction

Start with Elastomer::Client and the connection setup used by the Haystack initializer at config/initializers/elasticsearch.rb#L18-L20. Trace how the Faraday connection is exposed and determine where a logger-setting method belongs. Done means an app can configure the logger through Elastomer::Client without reaching into the Faraday object.

Written by the indexing model from the issue text.

Assessment

Tech stack
elasticsearch, ruby
Domain
backend-api-design, search
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.