github / github/elastomer-client

Logging

未关闭
#5 6 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Ruby
星标
197
派生
28
PR 合并指标
30 天内没有已合并 PR

描述

We need to add some logging to the `Client` class. For each request the client makes, we should output a detailed debug message to a logger of some sort. I really like how Tire does it; logging a curl command that you can copy/paste and use directly. Also, outputting the status code of the response would be good, too ...

```
[200] curl -XGET 'http://localhost:9200/index/_search' -d '...'
```

Not sure how to handle large bodies and what not. And I don't think we need to log responses.

cc @github/search

贡献指南

打开贡献指南

调研方向

Start by locating the Client class and tracing how it makes requests and receives responses. Review the project's existing logger conventions, then determine how to represent the request as a copyable curl command, handle large bodies, and include the response status without logging responses. Done means each request produces the agreed debug output with suitable tests.

由索引模型根据 Issue 内容生成。

评估

技术栈
elasticsearch, ruby
领域
api, observability
Issue 类型
功能
难度
4/5
预计耗时
3-5 天
活跃度
停滞
描述清晰度
需要澄清
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。