github / github/copilot-cli

OTel execute_tool bash span does not expose nonzero process exit outcome

未关闭
#4,864 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

triage
主要语言
Shell
星标
11.2k
派生
1.9k
平均合并
14 小时 16 分钟
30 天内合并 PR
6

描述

Describe the observability gap

When the shell tool successfully launches the synthetic command false, the resulting execute_tool bash span has status code 0 and no exit-code, error, result, or outcome attribute. Consumers cannot distinguish exit 0 from a nonzero command outcome in metadata-only telemetry.

This is distinct from a tool invocation failure: reading a guaranteed nonexistent synthetic path correctly produced an execute_tool view span with error status, error.type=failure, and an exception event.

Affected version

GitHub Copilot CLI 1.0.83 on macOS.

Steps to reproduce
  1. Enable metadata-only OTel file export.
  2. Run a synthetic prompt that directs the shell tool to execute exactly false once.
  3. Inspect the execute_tool bash span.

The tool execution output reports completion, while the span contains no metadata representing the subprocess's nonzero exit.

Expected behavior

It is reasonable for the tool invocation itself to be considered operationally successful, but metadata-only telemetry should expose a bounded, content-free command outcome such as process.exit.code=1 and/or a Copilot tool outcome attribute. The span status policy can remain separate from the subprocess exit status.

Privacy

The command is synthetic and harmless. Content capture was disabled; no command output, paths, repository data, or credentials are included.

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

首先使用 shell 工具运行合成命令 false,重现仅包含元数据的 OTel 导出,然后检查生成的 execute_tool bash span。完成的标准是:该 span 暴露一个有界且不含内容的非零子进程结果,例如 process.exit.code=1,或等效的工具结果属性,同时不捕获命令内容。

由索引模型根据 Issue 内容生成。

评估

技术栈
bash
领域
observability
Issue 类型
缺陷
难度
4/5
预计耗时
3-5 天
活跃度
活跃
描述清晰度
基本清楚
新手友好度
48/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。