github / github/copilot-cli

Local sandbox 'Authenticate gh' silently uses an unrelated cached fine-grained PAT instead of active gh OAuth session, with no visibility into which credential is chosen

Aperta
#4,804 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

triage
Lingua principale
Shell
Stelle
11.2k
Fork
1.9k
Merge medio
14h 16m
PR unite (30g)
6

Descrizione

Describe the bug

With local sandboxing enabled (/sandbox enable) and the "Authenticate gh" auth setting on (default), the GH_TOKEN exported into the sandboxed environment did not correspond to my active gh session.

  • gh auth status (run on the host, outside the sandbox) showed I was logged in via the OAuth device flow, with a gho_... token and scopes admin:public_key, gist, read:org, repo — i.e. full private repo access.
  • Inside a Copilot CLI sandboxed session, echo $GH_TOKEN / gh repo list <org> --visibility private showed access to only one private repository in my org, via a token in the fine-grained PAT format (github_pat_...).
  • After investigating, I found the actual token being used: an old fine-grained PAT I had created previously and scoped intentionally to a single, unrelated repository (not the repo I was actively working in).
  • This PAT is neither the active gh auth status OAuth session (keyring-stored gho_ token) nor the GitHub App ghu_ token found in ~/.config/github-copilot/auth.db.

I was unable to determine, from inside a Copilot CLI session or from documentation, why this specific cached PAT was selected over my active OAuth login, or where exactly it was being read from/cached. The lack of visibility made this very difficult to diagnose — I only found the answer by manually checking GitHub's "Active tokens" org admin page and recognizing a token I had created weeks earlier for unrelated purposes.

Expected behavior

When "Authenticate gh" is enabled for the local sandbox, I would expect one of the following:

  1. The sandbox's GH_TOKEN to be derived from the currently active gh auth status account/session (respecting gh auth switch), not from some other cached credential, OR
  2. If Copilot CLI intentionally uses a different/cached credential for the sandbox (e.g. a previously-supplied GH_TOKEN/GITHUB_TOKEN env var), this should be clearly surfaced to the user — e.g. via /sandbox or /env, showing which token/account is being exported into the sandbox and why, without requiring the user to manually diff PAT prefixes and check GitHub's org "Active tokens" page.
Reproduction steps
  1. Log in normally via gh auth login (OAuth device flow), confirm with gh auth status that the active session has broad repo scope.
  2. Separately, at some earlier point, create (or have previously created) a fine-grained PAT scoped to only one specific repository, for an unrelated purpose.
  3. Launch copilot, enable local sandboxing (/experimental on if needed, then /sandbox enable), leave "Authenticate gh" at its default (on).
  4. Inside the Copilot CLI session, ask the agent to run gh repo list <org> --visibility private or inspect $GH_TOKEN.
  5. Observe that the token exported into the sandbox matches the old, narrowly-scoped fine-grained PAT from step 2 — not the active OAuth session from step 1 — with no indication in the CLI of which credential was selected or why.
Additional context
  • /env and /sandbox do not currently surface which specific token/account was selected for GH_TOKEN in the sandbox, making this essentially undiagnosable without manual, external investigation (comparing token prefixes, checking org "Active tokens" pages, etc.).
  • Docs reference (Configuring local sandbox settings → Auth tab): "Authenticate gh: Export GH_TOKEN so that GitHub CLI ... works inside the sandbox without reaching its stored credentials (configuration directory or OS keychain), which the sandbox blocks." This explains that a substitute token is exported, but not how that substitute is selected when multiple credentials (OAuth session, GitHub App ghu_ token, cached fine-grained PATs) exist on the host.
  • Related open issues that touch on adjacent auth-scoping concerns: #1460 (no scoped-auth workflow vs gh auth login), #953 (default OAuth grants excessive scope).
Suggested improvement
  • Add a way to inspect, from within a session (e.g. /sandbox Auth tab or /env), exactly which token/account is currently selected for sandboxed gh/git operations, including its origin (active gh auth status session vs. a manually-set GH_TOKEN/GITHUB_TOKEN env var vs. some other cached credential) and its repository scope.
  • Consider making the sandboxed GH_TOKEN follow the currently active gh auth status account by default, rather than silently preferring a possibly-stale GH_TOKEN/GITHUB_TOKEN env var or other cached credential.

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Non è indicato alcun file di implementazione né alcun test. Inizia tracciando il percorso di autenticazione della sandbox locale dietro /sandbox enable, le viste Auth di /env e della sandbox e l’impostazione documentata Authenticate gh; confronta la selezione delle credenziali con gh auth status e ~/.config/github-copilot/auth.db. Il lavoro è completato quando l'origine e l'ambito della credenziale selezionata sono visibili e il comportamento di selezione riportato è coperto da un test di regressione.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
github, shell
Ambito
authentication, cli, security
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Attiva
Chiarezza
Abbastanza chiara
Idoneità per principianti
52/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.