github / github/copilot-cli

Plugin hooks are not loaded when a session is resumed via `--resume`

Abierto
#4,629 1 comentario 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

area:plugins area:sessions
Lenguaje dominante
Shell
Estrellas
11.2k
Forks
1.9k
Merge medio
14 h 16 min
PR fusionados (30 d)
6

Descripción

Summary

Plugin-provided hooks are not loaded when a session is started with --resume. The same plugin fires all of its hooks on a fresh session and none of them on a resumed one, in the same working directory, for the same session id, on the same machine.

loadDeferredRepoHooks() does run on the resume path — the fix for #1503 is in place — but it only restores repo/policy hooks. Hooks contributed by installed plugins are dropped, so any plugin that relies on SessionStart, UserPromptSubmit, Stop, or SessionEnd silently stops working the moment a user resumes.

Version: 1.0.81-14
OS: Windows 11 (pwsh)

Reproduction

A minimal plugin whose hooks only echo into a log file.

repro/.github/plugin/marketplace.json:

{
  "name": "repro-local",
  "description": "Minimal local marketplace for reproducing a hook loading bug",
  "owner": { "name": "repro" },
  "plugins": [
    {
      "name": "hook-probe",
      "description": "Appends one line to a log file for every hook event",
      "version": "0.1.0",
      "source": "./hook-probe"
    }
  ]
}

repro/hook-probe/plugin.json:

{
  "name": "hook-probe",
  "description": "Appends one line to a log file for every hook event",
  "version": "0.1.0",
  "hooks": "hooks/hooks.json",
  "author": { "name": "repro" },
  "license": "MIT"
}

repro/hook-probe/hooks/hooks.json:

{
  "hooks": {
    "SessionStart": [
      {
        "matcher": ".*",
        "hooks": [{ "type": "command", "bash": "echo SessionStart >> /tmp/hook-probe.log", "powershell": "echo SessionStart >> $env:TEMP\\hook-probe.log" }]
      }
    ],
    "UserPromptSubmit": [
      {
        "matcher": ".*",
        "hooks": [{ "type": "command", "bash": "echo UserPromptSubmit >> /tmp/hook-probe.log", "powershell": "echo UserPromptSubmit >> $env:TEMP\\hook-probe.log" }]
      }
    ],
    "Stop": [
      {
        "matcher": ".*",
        "hooks": [{ "type": "command", "bash": "echo Stop >> /tmp/hook-probe.log", "powershell": "echo Stop >> $env:TEMP\\hook-probe.log" }]
      }
    ],
    "SessionEnd": [
      {
        "matcher": ".*",
        "hooks": [{ "type": "command", "bash": "echo SessionEnd >> /tmp/hook-probe.log", "powershell": "echo SessionEnd >> $env:TEMP\\hook-probe.log" }]
      }
    ]
  }
}

Install it and run one fresh session and one resumed session:

$ copilot plugin marketplace add ./repro
$ copilot plugin install hook-probe@repro-local

$ rm $TEMP/hook-probe.log
$ copilot -p "reply with exactly: A" --allow-all-tools
...
Resume     copilot --resume=8561317a-5af2-4550-a42a-1f9b1f6058c3

$ cat $TEMP/hook-probe.log
UserPromptSubmit
SessionStart
Stop
SessionEnd

$ rm $TEMP/hook-probe.log
$ copilot --resume=8561317a-5af2-4550-a42a-1f9b1f6058c3 -p "reply with exactly: B" --allow-all-tools
...
$ cat $TEMP/hook-probe.log
cat: no such file — the hooks never ran

The resumed run completes normally (the model answers, tokens are billed), so the session itself is fine — only the plugin hooks are missing.

Expected vs actual

Run Hooks fired
copilot -p … UserPromptSubmit, SessionStart, Stop, SessionEnd
copilot --resume=<id> -p … none

Both runs use the same session id and the same trusted working directory. --resume is the only variable.

Debug log evidence

With "logLevel": "all", ~/.copilot/logs/process-*.log reports the hook count at load time. Two plugins were installed for this run (hook-probe contributing 4 hooks and an unrelated one contributing 5), on top of 5 policy hooks:

Fresh session:

[WARNING] Loading repo hooks in prompt mode (folder is trusted or opt-in set)
[DEBUG] loadDeferredRepoHooks(8561317a-5af2-4550-a42a-1f9b1f6058c3): invoked
[DEBUG] loadDeferredRepoHooks(8561317a-5af2-4550-a42a-1f9b1f6058c3): loaded repo hooks (hookCount=14)

Resumed session:

[DEBUG] resume-auto-cd: resolved persisted cwd -> <same directory>
[WARNING] Loading repo hooks in prompt mode (folder is trusted or opt-in set)
[DEBUG] loadDeferredRepoHooks(8561317a-5af2-4550-a42a-1f9b1f6058c3): invoked
[DEBUG] loadDeferredRepoHooks(8561317a-5af2-4550-a42a-1f9b1f6058c3): loaded repo hooks (hookCount=5)

14 → 5 is exactly the two plugins' 9 hooks going missing; the 5 that survive are the policy hooks loaded from HKLM\Software\Policies\GitHub\Copilot\Defender. So the resume path reloads repo/policy hooks and never re-attaches plugin hooks.

The dispatch points still fire — only the plugin handlers are missing

This is not a case of the resumed session skipping its hook points. ~/.copilot/session-state/<id>/events.jsonl records a hook.start / hook.end pair for each one, and the resumed run has them:

// resumed run
{"type":"hook.start","data":{"hookType":"userPromptSubmitted","input":{"prompt":"reply with exactly: B", ...}}}
{"type":"hook.end","data":{"hookType":"userPromptSubmitted","success":true}}
{"type":"hook.start","data":{"hookType":"sessionStart","input":{"source":"resume","initialPrompt":"reply with exactly: B", ...}}}
{"type":"hook.end","data":{"hookType":"sessionStart","success":true}}
{"type":"hook.start","data":{"hookType":"agentStop","input":{"stopReason":"end_turn", ...}}}
{"type":"hook.end","data":{"hookType":"agentStop","success":true}}

sessionStart is even dispatched with "source":"resume", so the resume path is aware it should run session-start hooks. Every hook.end reports success: true — yet hook-probe.log was never created, because no plugin-contributed handler was attached to any of those dispatch points.

So the bug is narrowly in plugin hook registration on the resume path, not in hook dispatch. success: true on an invocation that executed nothing also makes this invisible to anyone reading the transcript.

Ruled out

  • Folder trust. A fresh session in an untrusted directory (C:\Windows\system32) fires all four hooks. Both runs above log folder is trusted or opt-in set.
  • Plugin enablement. copilot plugin list shows the plugin (enabled) before and after the resumed run.
  • Live vs copied install. Reproduced with a directory-source (live) plugin; the plugin is listed and enabled either way.
  • A broken hook command. The identical hooks.json fires on the fresh run seconds earlier.

Impact

A resumed session is indistinguishable from a fresh one to the user, but every plugin hook is silently inactive. Plugins that use hooks for observability, session tracking, or policy enforcement fail open with no warning and no log line saying plugin hooks were skipped.

Related

#1503 covered the same symptom for repo hooks and was fixed by deferring and reloading them on resume. That reload does not include plugin-contributed hooks, which is what this issue is about.

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Empieza rastreando la ruta de reanudación y loadDeferredRepoHooks(), comparando el número de hooks en los registros de proceso proporcionados para sesiones nuevas y reanudadas. Usa la reproducción del plugin proporcionada y session-state//events.jsonl para verificar que los hooks aportados por el plugin se registran y ejecutan después de --resume, mientras los hooks de policy siguen cargándose. Se considera completado cuando la ejecución reanudada registra la salida del plugin para SessionStart, UserPromptSubmit, Stop y SessionEnd.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
shell
Área
cli, tooling
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Activo
Claridad
Bien especificado
Aptitud para principiantes
74/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.