Rubber duck reviews leave no verifiable record: independence and findings are unauditable after the session
还没有人认领这个 Issue。
- 主要语言
- Shell
- 星标
- 11.2k
- 派生
- 1.9k
- 平均合并
- 14 小时 16 分钟
- 30 天内合并 PR
- 6
描述
Describe the feature or problem you'd like to solve
Rubber duck reviews leave no verifiable record. The critique, the model that produced it, and what the session did with each finding all die with the session. #4380 and #4432 show why this matters: the independence guarantee (complementary family) can fail silently, and today the only way users can even detect that is by hand-extracting evidence from process logs and events.jsonl. The review's most valuable properties, who reviewed whom and what remained unresolved, are currently unauditable after the fact.
Proposed solution
Persist a small structured record per rubber duck invocation, next to the session or exportable to the repo: orchestrator model and family, reviewer model and family, how the reviewer was selected (complementary, inherited, explicitly overridden, and by whom), a hash of the review prompt, and the findings with their disposition (addressed, dismissed, left open).
Benefits: silent independence failures like #4380 and #4432 become visible in the record instead of requiring log forensics; teams can sample reviews after merge; and what the review left OPEN (unverified assumptions, accepted tradeoffs) survives as provenance instead of dying in the terminal.
Example prompts or workflows
- After a rubber duck pass,
/rubber-duck exportwrites the review record to a file the user can commit alongside the change. - A team samples merged PRs weekly and checks the records: which reviews ran cross-family, which findings were dismissed without evidence.
- CI warns when a PR's rubber duck record shows reviewer and orchestrator from the same family (the #4380 case, caught at review time instead of never).
- An auditor asks "what did the review leave open?" and gets an artifact, not a chat scrollback.
Additional context
Open disclosure: I maintain disensor (https://github.com/NicolasRocchia/disensor, MIT), a provider-neutral CLI and Action that formalizes exactly this record for adversarial review rounds (schema residue/v0.4: reviewer family and declared independence, prompt hash, findings with terminal states, residue declaration, CI gate). The method behind it is documented with data from 91 review events (DOI 10.5281/zenodo.21633495). Happy for any part of the schema to serve as reference or prior art; the point of this request is that the review record should exist, whoever implements it.
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
首先追踪 issue 中提到的 rubber-duck 调用,并检查流程日志和 events.jsonl 证据。定义每次调用如何记录模型、选择原因、提示词哈希、发现和处置方式,然后检查 /rubber-duck export 应如何输出该工件。完成的标准是记录在会话结束后仍然保留,并支持检查独立性和未解决的发现。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- shell
- 领域
- cli, observability
- Issue 类型
- 功能
- 难度
- 5/5
- 预计耗时
- 一周以上
- 活跃度
- 活跃
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100