github / github/copilot-cli

Server-managed extraKnownMarketplaces is fetched but never registers a marketplace (silent auth bail in plugin path)

Abierto
#4,556 3 comentarios 2 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

area:configuration area:plugins
Lenguaje dominante
Shell
Estrellas
11.2k
Forks
1.9k
Merge medio
14 h 16 min
PR fusionados (30 d)
6

Descripción

Describe the bug

A server-managed extraKnownMarketplaces entry is fetched successfully and parses correctly, but is never merged into the plugin/marketplace code path, so the marketplace is never registered. copilot plugin marketplace list shows only the two defaults, copilot plugin marketplace browse <name> reports "Marketplace not found", and the Copilot desktop app's Settings → Plugins pane shows only copilot-plugins and awesome-copilot.

The failure is completely silent — no error, no warning, no log line.

This appears distinct from #4039 and #4283, which both concern what happens after a managed marketplace/plugin is registered (sync-to-disk and enablement persistence). Here the marketplace is never registered at all, so no plugin from it is installable by any means.

Root cause

In app.js (1.0.80), the marketplace path self-fetches managed settings via XE():

async function XE(){
  let t = await yft();
  if (!t) return;              // bails -> returns undefined
  let e = await iP({selfFetch:!0, authInfo:{type:"user", host:t.host, login:t.login}});
  ...
}

async function A1(t,e,n){
  let r = await Nfe(t),
      s = Bg(e,n)?.extraKnownMarketplaces;   // e undefined -> s undefined
  return s ? {...r, extraKnownMarketplaces:{...s, ...r.extraKnownMarketplaces}} : r;
}

yft() resolves the account via authGetLastLoggedInUser(<configDir>/config.json). When the CLI has no local login record, it returns undefined, XE() bails, and A1() silently returns user settings only. B8() additionally wraps the call in .catch(()=>{}), so even a thrown error is swallowed.

This is reachable in normal use because the session path and the marketplace path resolve auth differently. When the CLI is driven by the desktop app (copilot --server --stdio), the app supplies auth to the session, and the session path fetches the policy fine — the same process logs:

[managedSettings] server policy received from https://github.com: bypassDisabled=false, keys=[enabledPlugins,extraKnownMarketplaces]

…while the marketplace path in that same process sees no account and skips the fetch entirely. So enterprise policy is demonstrably present and enforced (bypass-permissions restrictions apply), yet extraKnownMarketplaces is inert.

Affected version
copilot 1.0.80
GitHub Copilot desktop app 1.1.11
Steps to reproduce the behavior
  1. Publish a marketplace repo containing .claude-plugin/marketplace.json.
  2. Configure enterprise managed settings with:
{
  "extraKnownMarketplaces": {
    "acme": { "source": { "source": "github", "repo": "ACME/agent-plugins" } }
  },
  "enabledPlugins": {}
}
  1. Confirm the server actually returns it:
$ gh api /copilot_internal/managed_settings
{"extraKnownMarketplaces":{"acme":{"source":{"source":"github","repo":"ACME/agent-plugins"}}},"enabledPlugins":{}}
  1. Confirm the client receives it (from the app-spawned CLI log in ~/.copilot/logs/):
[managedSettings] server policy received from https://github.com: bypassDisabled=false, keys=[enabledPlugins,extraKnownMarketplaces]
  1. List marketplaces:
$ copilot plugin marketplace list
Included with GitHub Copilot:
  ◆ copilot-plugins (GitHub: github/copilot-plugins)
  ◆ awesome-copilot (GitHub: github/awesome-copilot)

$ copilot plugin marketplace browse acme
Failed to browse marketplace: Error: Marketplace "acme" not found

The acme marketplace is absent, and absent from the desktop app's Plugins pane.

Expected behavior

A marketplace declared in server-managed extraKnownMarketplaces should be registered and appear in copilot plugin marketplace list and in the desktop app's Plugins pane, exactly as the equivalent user-scope setting does.

Failing that, the policy fetch being skipped for lack of an account should produce a visible warning rather than silently degrading to user settings.

Additional context

The setting itself is valid — every other layer handles it correctly. Isolating each layer:

The identical JSON works at user scope, which rules out the shape/discriminator:

$ COPILOT_HOME=/tmp/cptest copilot plugin marketplace list
Registered marketplaces:
  • acme (GitHub: ACME/agent-plugins)

$ COPILOT_HOME=/tmp/cptest copilot plugin marketplace browse acme
Plugins in "acme":
  • ...   (all plugins resolve correctly)

The Rust resolver preserves the key from both layers. Calling the native module directly:

const h = require(".../prebuilds/darwin-arm64/runtime.node");
const j = JSON.stringify({
  extraKnownMarketplaces: { acme: { source: { source: "github", repo: "ACME/agent-plugins" } } },
  enabledPlugins: {}
});
h.managedSettingsResolveEffective(j, undefined);  // server layer
h.managedSettingsResolveEffective(undefined, j);  // device layer

Both return the key intact:

{"enabledPlugins":{},"extraKnownMarketplaces":{"acme":{"source":{"source":"github","repo":"ACME/agent-plugins"}}}}

The auth lookup is what fails. Against the real config:

await h.authGetLastLoggedInUser(os.homedir()+"/.copilot/config.json", spec);
// => undefined   (NO LOGGED-IN USER)

There is no CLI-side login record: the desktop app stores its token in its own data.db (github_accounts.access_token), and there is no Keychain entry for the CLI. So yft() cannot resolve an account even though the app is fully authenticated and the session path fetches policy successfully in the same process.

Note on the device/MDM path. Policy delivered via the device file (/Library/Application Support/GitHubCopilot/managed-settings.json) does not go through yft(), so validating a config that way can pass while server-delivered policy fails. Conformance testing that uses only the MDM path will not catch this.

Environment

  • Operating system: macOS 26.5.1
  • CPU architecture: arm64
  • Copilot CLI: 1.0.80 (engine spawned by the desktop app as copilot --server --stdio)
  • Copilot desktop app: 1.1.11
  • Policy source: server-managed (enterprise), confirmed via /copilot_internal/managed_settings

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Comienza en app.js siguiendo XE(), A1() y B8(), y luego compara la búsqueda de autenticación de la ruta de marketplace con la ruta de sesión que usa copilot --server --stdio. Reproduce la configuración gestionada por el servidor y verifica que acme marketplace aparezca en copilot plugin marketplace list y en el panel Plugins del escritorio, sin tragarse la política ni producir un fallback silencioso.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
github, javascript
Área
authentication, cli
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Activo
Claridad
Bastante claro
Aptitud para principiantes
55/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.