Fix browser login URL wrapping and fallback
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Shell
- Sterne
- 11.2k
- Forks
- 1.9k
- Ø Merge
- 14 Std. 16 Min.
- Gemergte PRs (30 T.)
- 6
Beschreibung
Describe the bug
The Device Code login flow works as expected: it displays a one-time code and URL, opens the URL automatically, and offers to copy the code to the clipboard when a key is pressed.
The Sign in with your browser (recommended) flow behaves differently. Although it displays a message such as “If your browser didn't open, visit:”, pressing a key does not open the browser. The fallback URL is also difficult or impossible to use in the terminal:
- The URL is long enough to wrap across terminal lines.
- Only the beginning of the URL (for example,
https://github.com/login/oauth/authorize?) is rendered as a clickable link. - The query string containing
client_idand the remaining parameters appears after the line break and is neither clickable nor reliably selectable/copied. - Resizing the terminal changes the wrapping behavior unpredictably; depending on the width, the URL may appear on one line with its end clipped or wrap inconsistently.
This prevents users from completing browser authentication when automatic browser opening fails.
Affected environment
- GitHub Copilot CLI
- Linux under WSL2
Steps to reproduce
- Start the GitHub Copilot CLI login flow.
- Select Sign in with your browser (recommended).
- Observe the fallback message and URL.
- Press a key when prompted.
- If the browser does not open, try selecting or clicking the displayed URL, then resize the terminal and observe the URL again.
Expected behavior
The browser login flow should use the same browser-opening behavior as the Device Code flow: pressing a key should open the browser automatically.
If automatic browser opening fails, the complete fallback URL should be rendered as one usable clickable link without being split into a non-interactive suffix. The CLI should also provide a final copy-to-clipboard option so users can paste the complete URL into a browser manually.
Additional context
Please preserve the full URL and its query parameters across terminal widths, or otherwise provide a terminal-safe presentation that remains clickable and copyable.
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne beim GitHub Copilot CLI-Anmeldeablauf und vergleiche den Pfad „Sign in with your browser“ mit dem Device Code-Flow. Verfolge die Darstellung der Fallback-URL über verschiedene Terminalbreiten hinweg; abgeschlossen ist die Aufgabe, wenn das Drücken einer Taste den Browser öffnet und eine vollständige Fallback-URL weiterhin anklickbar und kopierbar ist, mit einer abschließenden Zwischenablageoption.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- shell
- Bereich
- authentication, cli
- Issue-Typ
- Bug
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Ruhig
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 48/100