An empty model turn is persisted as `content: null` and permanently bricks the session
- 主要语言
- Shell
- 星标
- 11.2k
- 派生
- 1.9k
- 平均合并
- 14 小时 16 分钟
- 30 天内合并 PR
- 6
描述
## Summary
When a model returns a turn with **no text content and no tool calls**, Copilot persists it and replays it on every subsequent request as an assistant message with `"content": null` and no `tool_calls`. Against a strict OpenAI-compatible endpoint this is rejected, and because the bad message is now part of the conversation history, **every following turn in that session fails identically**. There is no way to recover the session from the UI.
Observed with a local model via Ollama's `/v1/chat/completions`, but the persistence/replay behaviour is provider-independent.
## Error surfaced to the user
```
Execution failed: CAPIError: 400 invalid message content type:
```
## Reproduction
1. Point Copilot at an OpenAI-compatible endpoint that validates message shape (e.g. Ollama `/v1/chat/completions`).
2. Use a model that occasionally ends a turn after reasoning without emitting content or a tool call.
3. Once such a turn occurs, every subsequent message in that session fails with the error above.
The rejected payload shape reduces to:
```bash
curl http://localhost:11434/v1/chat/completions \
-H 'Content-Type: application/json' -d '{
"model": "",
"messages": [
{"role": "user", "content": "hi"},
{"role": "assistant", "content": null}
]}'
# 400 invalid message content type:
```
The same payload **succeeds** if `content` is `""`, or if the field is omitted entirely, or if `tool_calls` is present alongside `content: null`.
## Why this looks like a Copilot-side bug
Per the OpenAI API schema for `ChatCompletionRequestAssistantMessage`:
> The contents of the assistant message. Required unless `tool_calls` or `function_call` is specified.
So `content: null` is only valid when accompanied by `tool_calls`. The server accepting null *with* tool calls and rejecting it *without* is consistent with that rule — the emitted message is the non-conformant part.
## Evidence from the session record
In `~/.copilot/session-state//events.jsonl`, 36 of 37 `assistant.message` events were normal tool-calling turns (`content: ''` plus exactly one `toolRequests` entry). Exactly one had neither:
```
model: | outputTokens: 105
content: ''
toolRequests: []
reasoningText: "<105 tokens of reasoning, then the turn ended>"
```
Every request after that point produced `session.error` with the 400 above. The corresponding rows in `session-store.db` show `assistant_response = NULL` for all subsequent turns in that session.
## Impact
A single empty model response is unrecoverable:
- The session cannot be continued — every new message re-sends the poisoned history.
- There is no UI affordance to delete, edit, or truncate the offending turn.
- The only workaround is abandoning the session and starting a new one, losing the conversation.
This is most likely to affect users running local or smaller models, where empty turns are more common, but the failure mode is not specific to any provider.
## Suggested fixes
Either would resolve it; the second is worth doing regardless:
1. **Serialize empty assistant content as `""` rather than `null`** when there are no tool calls (or omit the message entirely if it carries no content, tool calls, or other payload).
2. **Make an empty turn recoverable** — drop a content-less, tool-call-less assistant message when rebuilding history, and/or let the user delete the last turn so a session can't be permanently bricked by one bad response.
## Environment
- Copilot CLI/SDK: `1.0.73`
- Copilot desktop app on macOS 26.5.2 (Apple Silicon)
- Backend: Ollama 0.32.4, local model via `/v1/chat/completions`
贡献指南
调研方向
首先跟踪 ~/.copilot/session-state//events.jsonl 中的 assistant.message 事件如何被序列化并重放到 chat completion 请求中。将空事件与 session-store.db 中的 assistant_response 行进行比较,并针对 Ollama 的 /v1/chat/completions 端点进行复现。完成标准是:空的 assistant 轮次不再污染后续请求,并且无需放弃会话即可恢复该会话。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- shell
- 领域
- api, backend, cli, databases
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 冷清
- 描述清晰度
- 基本清楚
- 新手友好度
- 52/100