Code-review task agents can mutate the shared parent worktree
Nessuno ha ancora preso questa issue.
- Lingua principale
- Shell
- Stelle
- 11.2k
- Fork
- 1.9k
- Merge medio
- 14h 16m
- PR unite (30g)
- 6
Descrizione
Describe the bug
Native task agents launched with agent_type: code-review can mutate the shared parent worktree even though the agent type is described as read-only. In one two-reviewer panel, both prompts explicitly required read-only tools and forbade shell commands, scratch files, and repository writes. After the reviewers completed, the parent worktree contained 13 new untracked files and temporary repositories whose names matched the edge cases discussed in the review output.
Prompt-only read-only instructions are not an adequate boundary for a built-in agent advertised as read-only. A reviewer can silently contaminate or overwrite a parent's in-progress work.
Affected version
1.0.71
Steps to reproduce the behavior
- Start a project session with one intentional uncommitted file change.
- Record
git status --porcelain. - Invoke two background
taskcalls withagent_type: code-review. - In each reviewer prompt, require investigation through
view,rg, andglobonly, and explicitly forbid shell commands, scratch files, and all writes. - Ask the reviewers to inspect rename, file-mode, conflict, and submodule edge cases.
- Wait for both reviewers to complete and compare
git status --porcelainwith the snapshot.
The parent worktree gained these untracked artifacts:
source.txt
target.txt
test-conflict/
test-ita/
test-mode/
test-rename/
test-repo/
test-sub-target/
test-sub/
test_copy
test_copy.rs
test_mode
test_mode.rs
Removing exactly those post-snapshot artifacts restored the parent worktree. The workaround prevents this occurrence from contaminating the pull request, but it cannot prevent a reviewer from overwriting an existing parent file.
Expected behavior
A built-in code-review agent should have an enforced read-only tool profile, regardless of prompt text, so it cannot create, modify, or delete files in the parent worktree. If reviewer validation requires writes, the task should run in an isolated working copy or sandbox rather than the shared parent worktree.
Additional context
-
Environment: macOS arm64.
-
The reviewers were launched in background mode through the native
tasktool. -
The parent snapshot contained one modified tracked file and no untracked files before launch.
-
The most targeted fix would bind a read-only tool allowlist to the built-in
code-reviewagent. A broader fallback would isolate background task filesystems by default. -
Related sandbox and background-agent requests:
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Direzione di ricerca
Inizia tracciando gli avvii delle attività native per agent_type: code-review e l’entry point del tool-profile dell’agente integrato; usa git status --porcelain prima e dopo la riproduzione con due revisori. È completato quando l’agente code-review non può creare, modificare o eliminare file nel worktree padre e la validazione copre i casi elencati di rinomina, modalità, conflitto e submodule.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- git
- Ambito
- devtools, security
- Tipo di issue
- Bug
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Stato di attività
- Tranquilla
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 48/100