github / github/copilot-cli

copilot login auto-enters 'y/N' keychain prompt in v1.0.16 (regression: does not wait for user input)

Aberta
#2,494 11 comentários 1 reação 0 responsáveis Ver no GitHub
area:authentication
Linguagem predominante
Shell
Estrelas
11.2k
Forks
1.9k
Merge médio
14h 16min
PRs com merge (30d)
6

Descrição

### Describe the bug

After upgrading to version 1.0.16, running `copilot login` when the System Keychain is unavailable no longer prompts the user for (y/N) input as expected. Instead, the CLI auto-"enters" on behalf of the user without waiting for input, causing the authentication process to end/fail prematurely. This did not occur with version 1.0.14, which properly waited for user input.

This appears to be a regression or unintended side effect introduced in v1.0.16.

### Affected version

1.0.16 (regression from 1.0.14, which worked correctly)

### Steps to reproduce the behavior

1. Ensure your environment triggers the 'System Keychain unavailable' prompt (e.g., on Linux or a system without a keychain, or when permission is denied).
2. Run `copilot login` in the terminal.
3. Observe that version 1.0.16 does not wait for user input at the (y/N) prompt and auto-submits it, causing the authentication process to terminate.
4. In version 1.0.14, the prompt waits for user input and continues as expected.

### Expected behavior

CLI should always wait for explicit user input (y or N) at the "System Keychain unavailable" prompt and not proceed automatically. The authentication/login process should function as it did in 1.0.14.

### Additional context

- OS: Debian Distro, WSL
- Shell: /bin/bash
- Terminal emulator: Microsoft Terminal
- Regression coincides with changes introduced in 1.0.15 and 1.0.16 (input handling, mouse reporting, etc.)
- Possibly related: issue #2472 reports input/mouse handling changes in this timeframe, though for a different context.
- No open issues found that match this login prompt regression.

**Please advise if you need any more debugging or logs.**

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.