github / github/copilot-cli

ANSI escape stripping garbles output at PTY read boundaries

Aberta
#2,103 0 comentários 0 reações 0 responsáveis Ver no GitHub
area:terminal-rendering area:tools
Linguagem predominante
Shell
Estrelas
11.2k
Forks
1.9k
Merge médio
14h 16min
PRs com merge (30d)
6

Descrição

## Describe the bug

The bash tool's ANSI-stripping logic garbles output when escape sequences are split across PTY read boundaries. Fragments like `1m`, `]8;;`, or URL text from OSC 8 hyperlinks leak into captured output. The bug is non-deterministic — the same command can produce different garbled lines or sometimes render cleanly.

## Affected version

1.0.6

## Steps to reproduce

Run this in a Copilot CLI session (no dependencies needed — pure bash):

```bash
for d in $(seq -w 4 17); do
printf '\e]8;;https://example.com/2026-03-%s\aDate-%s\e]8;;\a \e[1mA\e[22m \e[36mB\e[39m \e[32mC\e[39m \e[31mD\e[39m\n' "$d" "$d"
done
```

Run multiple times. Some runs will show garbled output on one or more lines, such as:
```
Date-13 A B C D
ttps://example.com/2026-03-14Date-14 A B C D ← URL leaked
Date-15 A B C D
```
or:
```
Date-14]8;; A B C D ← OSC fragment leaked
```

Other runs of the exact same command will be completely clean.

## Expected behavior

All escape sequences should be fully stripped in every run, producing 14 identical lines of `Date-XX A B C D`.

## Additional context

The stripping appears to process bytes as they arrive from each PTY `read()` call. Since reads don't align with writes, an escape sequence can be split across two reads. Neither contains the complete sequence, so the regex fails to match and leaves fragments in the output. The non-determinism (different lines garbled across runs, sometimes clean) confirms this is a read-timing issue, not a regex pattern bug.

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.