github / github/codespaces-nextjs
Better support for non-x86-64 archs
- Dominant language
- JavaScript
- Stars
- 152
- Forks
- 210
- PR merge metrics
- No merged PRs in 30d
Description
Firstly, thanks for this awesome template! I'm pretty new to Next, so I'm sorry if this isn't a very good issue.
I believe that the `mcr.microsoft.com/devcontainers/universal:2` image used in this template is only built for `x86-64` arch according to https://github.com/microsoft/vscode-dev-containers/tree/main/containers/codespaces-linux. I'm guessing this is going to run into many performance issues for `amd64` users like me on Apple silicon.
I found a simple change like this seems to at least work enough for a template: https://github.com/github/codespaces-nextjs/compare/main...myyk:codespaces-nextjs:patch-1 (pls excused the misleading comment on it and the bad formatting)
I don't know if there are other reasons why `devcontainers/universal` was used instead of `devcontainers/typescript-node` though.
Contributor guide
Research direction
Inspect the template's devcontainer configuration and the `mcr.microsoft.com/devcontainers/universal:2` image declaration first. Compare it with the linked patch and check whether `devcontainers/typescript-node` provides the needed architecture support without losing existing template requirements. Done means the template works appropriately on non-x86-64 systems and the image choice is documented or validated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, next.js
- Domain
- devops
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100