github / github/codeql

False positive: CWE-918

Abierto
#9,306 2 comentarios 0 reacciones 0 asignados Ver en GitHub
acknowledged false-positive Go
Lenguaje dominante
CodeQL
Estrellas
10.1k
Forks
2.1k
Merge medio
2 d 15 h
PR fusionados (30 d)
141

Descripción

Test case:
```go
package main

import (
"net/http"
"net/url"
)

func testssrf(req *http.Request) {
host := req.URL.Query().Get("host")

u, _ := url.Parse("http://example")

// The current value of u is "http://example"
http.Get(u.String()) // Expected: negative Actual: positive

u.Host = host
http.Get(u.String())
}
```

The following code may have caused the false positives.
codeql-go/ql/src/semmle/go/security/RequestForgery.qll
```ql
override predicate isAdditionalTaintStep(DataFlow::Node pred, DataFlow::Node succ) {
// propagate to a URL when its host is assigned to
exists(Write w, Field f, SsaWithFields v | f.hasQualifiedName("net/url", "URL", "Host") |
w.writesField(v.getAUse(), f, pred) and succ = v.getAUse()
)
}
```

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.