False positive: CWE-918
- Dominant language
- CodeQL
- Stars
- 10.1k
- Forks
- 2.1k
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 141
Description
Test case:
```go
package main
import (
"net/http"
"net/url"
)
func testssrf(req *http.Request) {
host := req.URL.Query().Get("host")
u, _ := url.Parse("http://example")
// The current value of u is "http://example"
http.Get(u.String()) // Expected: negative Actual: positive
u.Host = host
http.Get(u.String())
}
```
The following code may have caused the false positives.
codeql-go/ql/src/semmle/go/security/RequestForgery.qll
```ql
override predicate isAdditionalTaintStep(DataFlow::Node pred, DataFlow::Node succ) {
// propagate to a URL when its host is assigned to
exists(Write w, Field f, SsaWithFields v | f.hasQualifiedName("net/url", "URL", "Host") |
w.writesField(v.getAUse(), f, pred) and succ = v.getAUse()
)
}
```
Contributor guide
Assessment
This issue has not been assessed yet.