github / github/codeql

FP? JS import assertions

Open
#9,104 0 comments 1 reaction 0 assignees View on GitHub
false-positive
Dominant language
CodeQL
Stars
10.1k
Forks
2.1k
Avg merge
2d 15h
Merged PRs (30d)
141

Description

**Description of the false positive**

```JS
import foo form "./foo.json" assert {type: "json"}
```

... is a proposed syntax update for JavaScript. It is already enabled in [V8](https://v8.dev/features/import-assertions) and [implemented](https://bugzilla.mozilla.org/show_bug.cgi?id=1736060) in SpiderMonkey/Firefox (not sure it is enabled yet). Given that it has two implementations, it should move to the final stage 4 this year.

I don't know what your policy is on green features like this, but you currently report it as a syntax error even though it works fine in Node.

**URL to the alert on the project page on LGTM.com**

https://lgtm.com/projects/g/compose-regexp/compose-regexp.js/snapshot/3384157884d8cd1de08fd9935400d4663327e40c/files/scripts/postpublish.js?sort=name&dir=ASC&mode=heatmap

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.