github / github/codeql

assignment is unnessary under suppress()

未关闭
#7,638 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
false-positive not security Python
主要语言
CodeQL
星标
10.1k
派生
2.1k
平均合并
2 天 15 小时
30 天内合并 PR
141

描述

Maybe a bit of an edge case, but this code gives warning of unnessary assignments:
```
t = "<>"
with suppress(AttributeError):
# Set to type arg.
t = cls = get_args(self.__orig_class__)[0]
# If a class, set to the qualname.
t = cls.__qualname__
```

It should probably recognise that any code in a `suppress()` block may not actually run to completion.

https://lgtm.com/projects/g/aio-libs/aiohttp/snapshot/d6d827d7b26f2a54999f8a150ef230fe627aa435/files/aiohttp/helpers.py?sort=name&dir=ASC&mode=heatmap#x6cb8804f71fae0f2:1

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。