github / github/codeql

LGTM.com - false positive

Open
#7,477 0 comments 0 reactions 0 assignees View on GitHub
false-positive
Dominant language
CodeQL
Stars
10.1k
Forks
2.1k
Avg merge
2d 15h
Merged PRs (30d)
141

Description

**Description of the false positive**

LGTM detects an overflow of the static array but the tag is sized 5 (TAG_SIZE+1) with a MACRO definition of TAG_SIZE set at 4.
It should not detect an overflow. Maybe it can alert on a misleading code since " tag[TAG_SIZE] = '\0' " would have been semantically better.

**URL to the alert on the project page on LGTM.com**

https://lgtm.com/projects/g/CGNS/CGNS/snapshot/a8ce0c1b1b48ddeb108dbed26ea49bc3b19cb217/files/src/adf/ADF_internals.c?sort=name&dir=ASC&mode=heatmap#x2675ef43068d1816:1

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.