github / github/codeql

General issue - "Loop variable capture" documentation

Open
#6,847 2 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
CodeQL
Stars
10.1k
Forks
2.1k
Avg merge
2d 15h
Merged PRs (30d)
141

Description

**Description of the issue**

See [**Loop variable capture**](https://lgtm.com/rules/7890089/):
https://lgtm.com/rules/7890089/

> ### Recommendation
>
> The simplest way to fix this problem is to add a local variable of the same name as the outer variable and initialize that using the outer variable as a default. for var in seq: ... def inner_func(arg): ... use(var) becomes for var in seq: ... def inner_func(arg, var=var): ... use(var)`

I think the code at the end of the paragraph is not supposed to be a one-liner. It should span multiple lines, with crucial but missing indentation.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.