github / github/codeql

LGTM.com - false positive - Use of the return value of a procedure

未关闭
#6,827 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
acknowledged false-positive not security Python
主要语言
CodeQL
星标
10.1k
派生
2.1k
平均合并
2 天 15 小时
30 天内合并 PR
141

描述

**Description of the false positive**

This is idiomatic Python and shouldn't raise a warning, even when the result of `main` is always `None`.
```python
if __name__ == "__main__":
sys.exit(main())
```
See:
https://docs.python.org/fr//3/library/__main__.html#packaging-considerations

> Since the call to `main` is wrapped in [`sys.exit()`](https://docs.python.org/fr//3/library/sys.html#sys.exit), the expectation is that your function will return some value acceptable as an input to [`sys.exit()`](https://docs.python.org/fr//3/library/sys.html#sys.exit); typically, an integer or `None` (which is implicitly returned if your function does not have a return statement).
>
> By proactively following this convention ourselves, our module will have the same behavior when run directly (i.e. `python3 echo.py`) as it will have if we later package it as a console script entry-point in a pip-installable package.

**URL to the alert on the project page on LGTM.com**

https://lgtm.com/projects/g/lamyj/odil/snapshot/00e9ad1ac34f7c310a264e3953e32d24b765cd2f/files/examples/python/convert.py?sort=name&dir=ASC&mode=heatmap#xf881ca92aa273c47:1

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。