github / github/codeql

LGTM.com - false positive - illegal raise of NoneType

未關閉
#6,573 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
acknowledged false-positive not security Python
主要語言
CodeQL
星號
10.1k
分支
2.1k
平均合併
2 天 15 小時
30 天內合併 PR
141

描述

**Description of the false positive**

```python
if not available_handlers:
[...]
raise RuntimeError(...)

last_exception = None
for handler in available_handlers:
try:
[...]
return
except Exception as exc:
[...]
last_exception = exc
[...]
raise last_exception # type: ignore[misc]
```
LGTM complains that `last_exception` can be `None`:
> Illegal class 'NoneType' raised; will result in a TypeError being raised instead.

This can happen only if the list `available_handlers` the loop iterates over is empty. We make sure `available_handlers` is **not** empty just before the loop.

**URL to the alert on the project page on LGTM.com**

https://lgtm.com/projects/g/pydicom/pydicom/snapshot/283a1a1994d3d01b4d1e1fb3959c4de35c3240a8/files/pydicom/dataset.py?sort=name&dir=ASC&mode=heatmap#xe8b0c26a5a33f9bc:1

https://lgtm.com/projects/g/pydicom/pydicom/snapshot/283a1a1994d3d01b4d1e1fb3959c4de35c3240a8/files/pydicom/dataset.py?sort=name&dir=ASC&mode=heatmap#x945aebd0a835900:1

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。