github / github/codeql

Java: `Annotation` has no source location for repeated annotation with implicit container

Aperta
#6,236 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Java question
Lingua principale
CodeQL
Stelle
10.1k
Fork
2.1k
Merge medio
2g 15h
PR unite (30g)
141

Descrizione

### Version
CodeQL CLI version: 2.5.7

### Description
When a [repeatable](https://docs.oracle.com/en/java/javase/16/docs/api/java.base/java/lang/annotation/Repeatable.html) annotation is used multiple times on an element (therefore creating an implicit container annotation), the respective `Annotation` elements have no source location.
This prevents writing queries reasoning about the location of these annotations, and also renders them unusable for query result output. Similarly they are not displayed in the AST viewer of the CodeQL VSCode extension either.

### Reproduction steps
1. Create a Java database for the following source code
```java
import java.lang.annotation.*;

class RepeatableAnnotationTest {
@Repeatable(Markers.class)
@interface Marker { }

@interface Markers {
Marker[] value();
}

// These don't have source locations
@Marker
@Marker
String implicitContainer;

// Though explicitly using a container annotation works
// The @Marker annotations have source locations
@Markers({
@Marker,
@Marker
})
String explicitContainer;
}
```
2. Run this CodeQL query:
```ql
import java

from Annotation a
where a.getCompilationUnit().fromSource()
select a
```
:x: The annotations with implicit container annotation have no source location; they do not appear in the result set

Note however, that for the implicit container annotation itself the current behavior of not having a source location is expected and desired (to differentiate between implicit and explicit container annotations).

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.