github / github/codeql

[Java] WildcardTypeAccess.hasNoBound() returns wrong result for array bounds

Open
#4,005 0 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
CodeQL
Stars
10.1k
Forks
2.1k
Avg merge
2d 15h
Merged PRs (30d)
141

Description

`WildcardTypeAccess.hasNoBound()` returns for wildcards bounded by an array type, that they have no bound.
Example query:
```ql
import java

from WildcardTypeAccess w
where
exists (w.getUpperBound())
and w.hasNoBound()
select w
```
[Query console link](https://lgtm.com/query/1406379471933943968/)

The issue appears to be that this predicate only checks for `TypeAccess` children, however `ArrayTypeAccess` is not a subclass of `TypeAccess`:
https://github.com/github/codeql/blob/595ab442e66a0911f836ae859faebcd3f4f0177d/java/ql/src/semmle/code/java/Expr.qll#L1589-L1590

Maybe it would suffice checking that any child expression at index 0 or 1 exists (or would that also match annotations somehow)?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.