github / github/codeql

Java: Nullness: LGTM.com - false positive

Abierto
#3,176 1 comentario 0 reacciones 0 asignados Ver en GitHub
false-positive Java
Lenguaje dominante
CodeQL
Estrellas
10.1k
Forks
2.1k
Merge medio
2 d 15 h
PR fusionados (30 d)
141

Descripción

**Description of the false positive**

```java
if (!channel.isActive()) {
CompletableFuture currentFuture;
synchronized (channelPool) {
currentFuture = channelPool.get(offset);
if (currentFuture == finalFuture) { // final future is not null since it is used also before
channelPool.set(offset, null);
} else if (currentFuture == null) {
currentFuture = factory.apply(address); // <== assigned here
currentFuture.whenComplete(this::logConnection); // <== used here
channelPool.set(offset, currentFuture);
}
}

if (currentFuture == finalFuture) {
getChannel(address, messageType)
.whenComplete(
(recursiveResult, recursiveError) -> {
completeFuture(future, recursiveResult, recursiveError);
});
} else {
currentFuture.whenComplete( // <== can't be null here
```

We can see that if currentFuture is null then it is assigned a new value, which is used directly afterwards, which means it cant be null later.
**URL to the alert on the project page on LGTM.com**
https://lgtm.com/projects/g/zeebe-io/zeebe/snapshot/e722021d676bdbeee3366fa1c10a915f031bbf0c/files/atomix/cluster/src/main/java/io/atomix/cluster/messaging/impl/ChannelPool.java?sort=name&dir=ASC&mode=heatmap#xa937c5d4af2d26c1:1

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.