github / github/codeql

LGTM.com - false positive

Open
#3,134 1 comment 0 reactions 0 assignees View on GitHub
C# false-positive
Dominant language
CodeQL
Stars
10.1k
Forks
2.1k
Avg merge
2d 15h
Merged PRs (30d)
141

Description

**Description of the false positive**
The code in question is already checking if the value is null or not. I think the algorithm might be getting tripped up on the `||` of the first `if` statement highlighted.

**URL to the alert on the project page on LGTM.com**
https://lgtm.com/projects/g/jpopadak/CoreMatchers/latest/files/src/CoreMatchers/Matchers/IsEqual.cs#x3b4e50392ea9d8ef:1

**Code in question**
https://github.com/jpopadak/CoreMatchers/blob/master/src/CoreMatchers/Matchers/IsEqual.cs#L70-L91

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.