github / github/codeql

LGTM.com - false positive - Java - Netty Response Splitting

未關閉
#2,908 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
false-positive Java
主要語言
CodeQL
星號
10.1k
分支
2.1k
平均合併
2 天 15 小時
30 天內合併 PR
141

描述

**Description of the false positive**

When the `DefaultFullHttpResponse` is used in a limited scope where it's provable that no headers are added from sources other than static locations, this is a safe place where verification is safe to disable.

Since this query already gets so few hits, I think that it's safe to continue to flag all other cases, even when QL can't prove that user supplied data flows to netty because many libraries are simply wrappers for netty so wouldn't directly show data flow from user supplied data.

**URL to the alert on the project page on LGTM.com**

- https://lgtm.com/projects/g/eclipse-vertx/vert.x/snapshot/229594b9c483132e6efa5c24f66f826a990b53de/files/src/main/java/io/vertx/core/http/impl/Http1xUpgradeToH2CHandler.java?sort=name&dir=ASC&mode=heatmap#L83
- https://lgtm.com/projects/g/eclipse-vertx/vert.x/snapshot/229594b9c483132e6efa5c24f66f826a990b53de/files/src/main/java/io/vertx/core/http/impl/Http1xUpgradeToH2CHandler.java?sort=name&dir=ASC&mode=heatmap#L113

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。