github / github/codeql

LGTM.com - false positive - cs/unused-collection when usage is within methods that caller overrides within an abstract class

未關閉
#2,776 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
C# false-positive
主要語言
CodeQL
星號
10.1k
分支
2.1k
平均合併
2 天 15 小時
30 天內合併 PR
141

描述

**Description of the false positive**

The `cs/unused-collection` is resulting in some false positives: https://lgtm.com/rules/1506094606044/

**URL to the alert on the project page on LGTM.com**

https://lgtm.com/projects/g/dotnet/corefx/snapshot/4fed824926d1c659c494bd5261fbae0236b2e9da/files/src/System.Linq.Expressions/src/System/Runtime/CompilerServices/CallSiteBinder.cs?sort=name&dir=ASC&mode=heatmap#x343810f1b8fd4a23:1

In this particular case, the collection is initialized here and then passed to an abstract method (so the caller could have needed/accessed the elements):
Initialized: https://source.dot.net/#System.Linq.Expressions/System/Runtime/CompilerServices/CallSiteBinder.cs,7785087df39cf34b
Passed to an abstract method: https://source.dot.net/#System.Linq.Expressions/System/Runtime/CompilerServices/CallSiteBinder.cs,129
User defined method that overrides it accesses the collection elements: https://source.dot.net/#System.Linq.Expressions/System/Runtime/CompilerServices/CallSiteBinder.cs,9c8a7458b545d05d

For example, see:
https://source.dot.net/#System.Linq.Expressions/System/Dynamic/DynamicMetaObjectBinder.cs,49

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。