github / github/codeql

LGTM.com - false positive - cs/equals-on-unrelated-types for types like Uri that override Equals

Ouverte
#2,751 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
C# false-positive
Langage dominant
CodeQL
Étoiles
10.1k
Forks
2.1k
Merge moyen
2 j 15 h
PR mergées (30 j)
141

Description

**Description of the false positive**

In general, the `cs/equals-on-unrelated-types` rule makes sense: https://lgtm.com/rules/1506096656531/

However, there are certain types, such as `Uri` which handle specific sets of types for equality in the `Equals` override method. In this particular case, `Uri.Equals` allows for the object to be `string` and tries to create a `Uri` from that string before comparing.
https://github.com/dotnet/runtime/blob/94ca567c76d4b2a8a5b2e744e3d9559abbcefdb0/src/libraries/System.Private.Uri/src/System/Uri.cs#L1629-L1657

**URL to the alert on the project page on LGTM.com**

https://lgtm.com/projects/g/dotnet/corefx/snapshot/4fed824926d1c659c494bd5261fbae0236b2e9da/files/src/System.Private.Uri/src/System/UriBuilder.cs?sort=name&dir=ASC&mode=heatmap#V364

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.